Skip to content

Remove northeurope from random region selection to be used for perf tests #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Remove northeurope from random region selection to be used for perf tests #5358

merged 1 commit into from
Jan 7, 2025

Conversation

@Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jan 7, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2025
@codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (71a3924) to head (d75a99a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5358   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         272      272           
  Lines       29401    29401           
=======================================
  Hits        15417    15417           
  Misses      13178    13178           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackfrancis
Copy link
Contributor

/cherry-pick release-1.16
/cherry-pick release-1.17

@k8s-infra-cherrypick-robot
Copy link

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.16, release-1.17 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Jont828 Jont828 force-pushed the remove-random-region branch from 3b309be to d75a99a Compare January 7, 2025 23:19
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
jackfrancis
jackfrancis approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06f1d32c547e08b85246c4e60b5f016fc6a8bedd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@jackfrancis jackfrancis merged commit c10397e into kubernetes-sigs:main Jan 7, 2025
12 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 7, 2025
@k8s-infra-cherrypick-robot
Copy link

@jackfrancis: new pull request created: #5359

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@jackfrancis: new pull request created: #5360

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

Assignees

@jackfrancis jackfrancis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

4 participants

@Jont828 @jackfrancis @k8s-infra-cherrypick-robot @k8s-ci-robot